Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Delete an AWS Thing Type #1806

Closed
Tracked by #1865
hocinehacherouf opened this issue Feb 26, 2023 · 0 comments · Fixed by #2050
Closed
Tracked by #1865

Task: Delete an AWS Thing Type #1806

hocinehacherouf opened this issue Feb 26, 2023 · 0 comments · Fixed by #2050
Assignees
Labels

Comments

@hocinehacherouf
Copy link
Contributor

hocinehacherouf commented Feb 26, 2023

Is your feature request related to a problem? Please describe.

Blocked by #1802

Users must be able to delete a deprecated thing type (Only a deprecated thing type)

Documentation: https://docs.aws.amazon.com/iot/latest/developerguide/thing-types.html

Describe the solution you'd like

Backend:

  • Create/update a service that:
    • Sends a request to AWS to deprecated a thing type: You can use the method DeleteThingTypeAsync to do that
    • If the request is successful, the thing type should be deleted from the database using EF
    • Otherwise an exception should thrown with a human readable message
  • Create a REST endpoint that allow HTTP clients to delete a deprecated thing type
    • ⚠️ Use DTO for data exchange between controllers and services layers. Controllers should never handle AWS or internal objects.

Frontend:

  • Add a method on service layer that calls the backend to delete a deprecated thing type.
@github-project-automation github-project-automation bot moved this to 📝 Todo in IoT Hub Portal Feb 26, 2023
@kbeaugrand kbeaugrand changed the title Feature: Delete an AWS Thing Type Task: Delete an AWS Thing Type Mar 11, 2023
@ssgueye2 ssgueye2 self-assigned this Apr 28, 2023
@ssgueye2 ssgueye2 moved this from 📝 Todo to 🚧 In Progress in IoT Hub Portal May 10, 2023
@ssgueye2 ssgueye2 moved this from 🚧 In Progress to 💬 Ready for Review in IoT Hub Portal May 11, 2023
@kbeaugrand kbeaugrand linked a pull request May 11, 2023 that will close this issue
9 tasks
@kbeaugrand kbeaugrand removed the status in IoT Hub Portal May 11, 2023
@kbeaugrand kbeaugrand moved this to 🚀 Ready in IoT Hub Portal May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🚀 Ready
Development

Successfully merging a pull request may close this issue.

4 participants