Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Use git submodule to reference iotedge-lorawan-starterkit for bicep templates #2252

Closed
hocinehacherouf opened this issue Jun 24, 2023 · 0 comments · Fixed by #2347
Closed
Assignees
Labels
enhancement New feature or request

Comments

@hocinehacherouf
Copy link
Contributor

Is your feature request related to a problem? Please describe.
To test/dev bicep templates, we have to download the code source of iotedge-lorawan-starterkit to the folder templates/azure

Describe the solution you'd like
We can improve this use case by using git submodules.

Under path templates/azure, add a git submoldule targeting iotedge-lorawan-starterkit:

cd templates/azure

git submodule add https://github.com/Azure/iotedge-lorawan-starterkit.git

Update also the ci job validate_arm_templates:

Replace

- uses: actions/checkout@v3.5.3
- name: Checkout Azure/arm-ttk
uses: actions/checkout@v3.5.3
with:
repository: Azure/arm-ttk
path: arm-ttk
- name: Checkout Azure/iotedge-lorawan-starterkit
uses: actions/checkout@v3.5.3
with:
repository: Azure/iotedge-lorawan-starterkit
ref: dev
path: templates/iotedge-lorawan-starterkit

By

- uses: actions/checkout@v2
  with:
    submodules: recursive
@hocinehacherouf hocinehacherouf added enhancement New feature or request refinement labels Jun 24, 2023
@github-project-automation github-project-automation bot moved this to 📝 Todo in IoT Hub Portal Jun 24, 2023
@hocinehacherouf hocinehacherouf self-assigned this Jul 24, 2023
@hocinehacherouf hocinehacherouf changed the title Feature: Uee git submodule to reference iotedge-lorawan-starterkit for bicep templates Feature: Use git submodule to reference iotedge-lorawan-starterkit for bicep templates Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📝 Todo
Development

Successfully merging a pull request may close this issue.

1 participant