-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test variable grid spacing for C grid - part2 #791
Comments
I checked the discretization in the overleaf document. It looks okay to me, just one question about a sign in the replacement pressure, which should not affect symmetry. There might be a typo in the translation from the document to the code. There, we should be able to replace i with j and j with i (which will change off-diagonal array elements but not the diagonal i,j and i+1,j+1 elements), and come up with the same discretization for each term but rotated 90 degrees and probably flipped in sign for some of them. |
Thanks for checking the discretization. Is the error in the code or the document? |
The comment is in the document. Not sure whether it's an error. |
Ok I will have a look. Thanks! |
It is weird for the C grid. Is it due to the fact that P*=2.75e4? I have seen problems before with stiff problems (e.g. issue #697). Let's try with P*=1e4. |
As shown in issue #792, the checkerboard pattern in the corner is related to the remapping. I am going to use upwind for the rest of the tests here to see if there is still thickening in corners with the C grid. dt=1h Let's look at the solutions after 1 month. |
I have verified and the diff between EVP (B grid) and VP (B grid) are very small (~1 mm, not shown). |
See also issue #786.
The text was updated successfully, but these errors were encountered: