Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Found one remaining #ifdef ncdf not covered by USE_NETCDF #796

Closed
phil-blain opened this issue Nov 28, 2022 · 2 comments · Fixed by #797
Closed

Found one remaining #ifdef ncdf not covered by USE_NETCDF #796

phil-blain opened this issue Nov 28, 2022 · 2 comments · Fixed by #797
Labels
Build Software Engineering

Comments

@phil-blain
Copy link
Member

phil-blain commented Nov 28, 2022 •
edited
Loading

I just stumbled upon these lines:

CICE/cicecore/cicedynB/analysis/ice_history.F90

Lines 421 to 423 in 4f7f7cf

#ifndef ncdf
f_bounds = .false.
#endif

All other uses of ncdf were cleaned up and the macro renamed to USE_NETCDF in #490, but this one was forgotten, I think.

I'm not sure of the implications as I did not look further, apart to find out that it dates back to CICE-Consortium/CICE-svn-trunk@f41374d.

@apcraig
@phil-blain
Copy link
Member Author

Looking at that a bit, I think we should just remove those 3 lines, and let f_bounds acquire its value from the namelist as the rest of the f_* variables.

I'm not sure I understand why it was special-cased...

@apcraig
Copy link
Contributor

apcraig commented Nov 30, 2022

Fixing this week. Thanks @phil-blain

@apcraig apcraig mentioned this issue Nov 30, 2022
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build Software Engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Icepack to #5999551 including snowbrinebugs apcraig/CICE
2 participants
@apcraig @phil-blain