Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set l_fixed_area=T when C grid (and remap) is used #832

Closed
JFLemieux73 opened this issue Jun 6, 2023 · 4 comments
Closed

Set l_fixed_area=T when C grid (and remap) is used #832

JFLemieux73 opened this issue Jun 6, 2023 · 4 comments
Assignees
Labels

Comments

@JFLemieux73
Copy link
Contributor

The code should be modified so that l_fixed_area is always set to True wtih the C grid (and remap). See issues #792, #809 and #811 for details.

An additional test should be added to the suite ( C grid, remap l_fixed_area=T).

@JFLemieux73
Copy link
Contributor Author

Maybe we should also modify the doc to justify the use of l_fixed_area=T.

@JFLemieux73
Copy link
Contributor Author

add variable in module rmap and set l_fixed_area=F or T whether B or C grid in remap init

@JFLemieux73
Copy link
Contributor Author

I have modified the code so that l_fixed_area is set in init_remap depending of the grid.

The baseline tests assume that l_fixed_area=.false. So at first, I wanted to verify that the end-2-end testing procedure is BFB if l_fixed_area = .false. whatever the grid. So I tested with

if (grid_ice == 'CD' .or. grid_ice == 'C') then
l_fixed_area = .false.
else
l_fixed_area = .false.
endif

It is indeed BFB:

349 measured results of 349 total results
349 of 349 tests PASSED
0 of 349 tests PENDING
0 of 349 tests MISSING data
0 of 349 tests FAILED

@apcraig
Copy link
Contributor

apcraig commented Jun 19, 2023

See #833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants