Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

重新思考 FIcon 组织方式 #151

Open
1 task
CLDXiang opened this issue Apr 11, 2021 · 0 comments
Open
1 task

重新思考 FIcon 组织方式 #151

CLDXiang opened this issue Apr 11, 2021 · 0 comments
Labels
💬 discussing Some issues to be discussed ☘ enhancement Optimization or extension on existing feature

Comments

@CLDXiang
Copy link
Owner

🤔 动机 / 原因

目前的 FIcon 采用 v-if / v-else 来强行切换选用的图标,每一次添加新图标都需要硬改组件内代码,极容易造成合并冲突,而且文件会越来越长且无法拆分,可以思考如何解耦地设计该组件,使得新增 、删除、修改图标变得更加容易

💡 期望的解决方案

  • 或许可以将不同 Icon 分文件放到一个目录下,外部调用图标的方式保持不变
  • 也可以考虑引入其他优秀的 CDN 图标库或 NPM 图标库,可以等待 UI 稿再决定图标库的选取

👀 更多信息

  • 定下方案
@CLDXiang CLDXiang added the ☘ enhancement Optimization or extension on existing feature label Apr 11, 2021
@CLDXiang CLDXiang added the 💬 discussing Some issues to be discussed label Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💬 discussing Some issues to be discussed ☘ enhancement Optimization or extension on existing feature
Projects
None yet
Development

No branches or pull requests

1 participant