Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WorldBank tests fail #835

Closed
peanutfun opened this issue Jan 11, 2024 · 1 comment
Closed

WorldBank tests fail #835

peanutfun opened this issue Jan 11, 2024 · 1 comment
Labels
blocker immediate attention required help wanted

Comments

@peanutfun
Copy link
Member

The following two tests fail in the current version of develop:

FAILED climada/util/test/test_finance.py::TestWBWealthAccount::test_pca_CUB_2015_pass - AssertionError: 108675513472.0 != 108675762920.0
FAILED climada/util/test/test_finance.py::TestWBWealthAccount::test_tow_IND_1985_pass - AssertionError: 5861186367245.2 not found in [5415188681934.5, 5861193808779.6, 5861186556152.8]

I think this is because some World Bank data, which this module downloads, has changed. I think a similar thing happened before: 4f191e8. @emanuel-schmid, could you maybe have a look?

This issue currently causes all pipelines to fail.
@peanutfun peanutfun added help wanted blocker immediate attention required labels Jan 11, 2024
@emanuel-schmid emanuel-schmid mentioned this issue Jan 17, 2024
Merged
13 tasks
@peanutfun
Copy link
Member Author

Solved by #841. Thank you, @emanuel-schmid! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker immediate attention required help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peanutfun