Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #573

Closed
3 tasks done
henryiii opened this issue Apr 3, 2021 · 0 comments
Closed
3 tasks done

Fix CI #573

henryiii opened this issue Apr 3, 2021 · 0 comments

Comments

@henryiii
Copy link
Collaborator

henryiii commented Apr 3, 2021

Cataloging current problems in CI, which are blocking merges and development.

  • CMake check broken due to missing docker image. Probably move this from a docker action to the setup-cmake action. Maybe use a local composite action.
  • Clang 3.4 broken due to GoogleTest
  • C++20 broken due to GoogleTest.

Solution to the GoogleTest issues likely is to move the GTest step to a download, and possibly use older GTest with older compilers. Wishing I'd used Catch2 now...

Converted to Catch2 in #574.

@henryiii henryiii closed this as completed Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant