Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding size instead of expected + unchangable #92

Merged
merged 4 commits into from
Apr 4, 2018
Merged

Adding size instead of expected + unchangable #92

merged 4 commits into from
Apr 4, 2018

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Mar 26, 2018

Working on #87.

  • Move to using two values instead of one for expected: expected and type_size. Drop unchangable, which was really just a hack for not knowing the type size.
  • Expand policies to support multiple options
  • Check/expand support for expected -N where N>1.
  • Check/fix help printout for typeval > 1. Add test. (@AbcAeffchen)

@henryiii henryiii force-pushed the sizes branch 2 times, most recently from c08258a to d3903a7 Compare March 26, 2018 09:16
@codecov
Copy link

codecov bot commented Mar 26, 2018

Codecov Report

Merging #92 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #92   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines        1399   1409   +10     
=====================================
+ Hits         1399   1409   +10
Impacted Files Coverage Δ
include/CLI/Error.hpp 100% <100%> (ø) ⬆️
include/CLI/App.hpp 100% <100%> (ø) ⬆️
include/CLI/Option.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de06d50...d2ec24f. Read the comment docs.

@henryiii
Copy link
Collaborator Author

henryiii commented Apr 2, 2018

@AbcAeffchen, can you check and see if printout works (and patch if it doesn't), and maybe add a test to help test that checks for your expected printout? Any tests you can think of are appreciated, really. :)

Otherwise, I think this is about ready.

@henryiii henryiii changed the title WIP: Adding size instead of expected + unchangable Adding size instead of expected + unchangable Apr 2, 2018
@henryiii
Copy link
Collaborator Author

henryiii commented Apr 4, 2018

Going to go ahead and merge, feel free to add a test/fixes for your use case and PR!

@henryiii henryiii merged commit 9a1ac48 into master Apr 4, 2018
@henryiii henryiii deleted the sizes branch April 4, 2018 18:32
@henryiii henryiii added this to the v1.5 milestone Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant