Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy Breaking Change #59

Closed
rya-sge opened this issue Oct 14, 2022 · 0 comments · Fixed by #63
Closed

Proxy Breaking Change #59

rya-sge opened this issue Oct 14, 2022 · 0 comments · Fixed by #63
Assignees
Labels
bug Something isn't working Critical Issue It is very important to fix this issue.

Comments

@rya-sge
Copy link
Collaborator

rya-sge commented Oct 14, 2022

The function initializer must not be called in the constructor.

In the constructor, we need only the call to the ERC2771 / MetaTxModule constructor
Possible patch

constructor(
        address forwarder,
    ) MetaTxModule(forwarder) {
    }

    function initialize(
        address owner,
        string memory name,
        string memory symbol,
        string memory tokenId,
        string memory terms
    ) public initializer {
        __CMTAT_init(owner, name, symbol, tokenId, terms);
    }
@rya-sge rya-sge added bug Something isn't working Critical Issue It is very important to fix this issue. labels Oct 14, 2022
@rya-sge rya-sge self-assigned this Oct 18, 2022
@rya-sge rya-sge linked a pull request Oct 28, 2022 that will close this issue
@veorq veorq closed this as completed in #63 Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Critical Issue It is very important to fix this issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant