Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rastertools documentation #18

Open
cadauxe opened this issue Oct 30, 2024 · 0 comments
Open

Rastertools documentation #18

cadauxe opened this issue Oct 30, 2024 · 0 comments

Comments

@cadauxe
Copy link

cadauxe commented Oct 30, 2024

Here are some observations about the documentation.
We can categorize the documentation into three main sections: User, Developer, and a dedicated Testing section.
 
For the User Documentation,
 
We encountered some difficulties navigating the command-line interface (CLI) section. We believe it would be clearer if there were direct links to the relevant class documentation (currently located in the API Reference), allowing for easier access to detailed information about image processing methods, including specifics like applied formulas.
 
Regarding the Developer Documentation,
 
To better understand function inputs and outputs, it is essential to include type annotations for both expected input parameters and returned objects. This would also help developers become more familiar with the API, especially as it becomes accessible to users through NumPy objects.
 
Lastly, on the Testing Documentation,
 
The tests can serve as a demonstration of the library's capabilities. However, current tests have minimal documentation and lack context about what is being tested and the expected results. The tests appear to be fairly general, focusing primarily on issues such as missing a required argument, rather than demonstrating the function's capability to perform the intended processing.
In fact in svf and hillshade calculations, we noticed that test.run_test(check_outputs=False)is executed within the test with compare=False, so the results of both functions are not compared to reference outputs. Could we have more information about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant