Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The parser callback system is too coarse-grained #15

Open
jcbollinger opened this issue Jan 13, 2016 · 1 comment
Open

The parser callback system is too coarse-grained #15

jcbollinger opened this issue Jan 13, 2016 · 1 comment

Comments

@jcbollinger
Copy link
Contributor

The parser's syntax-level callbacks are too coarse-grained to accurately reflect the details of whitespace inside complex data values. This makes it impossible for cif_linguist, say, to accurately preserve whitespace in CIF 2 or STAR 2 input.

@jcbollinger
Copy link
Contributor Author

Recasting the nature of the whitespace callback and the meaning of zero-length whitespace runs permits cif_linguist to accurately preserve whitespace. It's still a bit tricky and cumbersome, but it works well enough.

I am leaving this issue open for the time being, however, to suggest coming back to it when the next major revision is planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant