Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _alias.dictionary_uri to aliases where possible #482

Open
vaitkus opened this issue Feb 20, 2024 · 1 comment · May be fixed by #483
Open

Add _alias.dictionary_uri to aliases where possible #482

vaitkus opened this issue Feb 20, 2024 · 1 comment · May be fixed by #483

Comments

@vaitkus
Copy link
Collaborator

vaitkus commented Feb 20, 2024

The DDLm reference dictionary defines the _alias.dictionary_uri attribute, however, it does not seem to be widely used in the CIF_CORE or any other of the IUCr dictionaries. This information would be useful since it would allow to more easily track down the origin of a specific alias and to double check if the definitions in different dictionaries haven't diverted too much. However, the semantics of _alias.dictionary_uri currently seem a bit unclear to me so it would be great to resolve that first (see issue #481).

Also, there were some discussions in PR #479 of adding the URI to deprecated items. I will prepare a separate draft PR and link it to this issue.

@vaitkus
Copy link
Collaborator Author

vaitkus commented Feb 20, 2024

PR #483 introduces the _alias.dictionary_uri values for deprecated aliases. The URIs were chosen to refer to the versions of the dictionary in which those specific aliases were deprecated. These URIs might need to be changed if the definition of the _alias.dictionary_uri attribute get reworded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant