Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the script to validate example CIF files #7

Open
vaitkus opened this issue Sep 2, 2021 · 1 comment
Open

Update the script to validate example CIF files #7

vaitkus opened this issue Sep 2, 2021 · 1 comment

Comments

@vaitkus
Copy link
Collaborator

vaitkus commented Sep 2, 2021

Currently, the action validates all of the CIF dictionaries (*.dic) in the top-most directory (.) against the DDLm Reference (ddl.dic) dictionary. I propose to extend the validation behaviour to validate the provided example CIF files against the given CIF dictionaries. The example file could either be placed in a pre-agreed directory (i.e. examples) or made configurable via a yaml file.

For example, the TopoCif [1] repository has several CIF examples that are placed in the examples directory that would benefit from automatic additional checks.

[1] https://github.com/COMCIFS/TopoCif

Does this seem useful to others as well?

@jamesrhester
Copy link
Contributor

This would be a fantastic enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants