-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
u² is saved under variable name u (possibly same for v): confusion for cosima-cookbook database #234
Comments
@aekiss - this is a good point. Is there any way you can run a quick check on all the standard configs to ensure that there are no other variables being saved with a common name? We should then change the default names for these two files in the control directories -- I guess that needs a change in the logic of |
This issue would affect any variable that is output with multiple In the case of |
new MOM issue re. units: mom-ocean/MOM5#335 |
@aekiss, I see your point eg regarding u snap and u monthly mean. These are two different reduction methods. But u^2 is not a reduction method. It's a different quantity. You can still have u^2 snap and u^2 monthly mean etc. Am I wrong? An issue that arises is that cookbook's data explorer doesn't suggest the user to prescribe also the appropriate ncfile argument and therefore confusion is generated and propagated to the following generations. (cc @aidanheerdegen). Is there at least some way for dataexplorer to inform the naïve user that u might also mean u^2 or u^4 and what not? This would be perhaps a way around this issue. 2 cents deposited |
Would adding |
Yes u^2 is a different physical quantity but it's specified as a If the cookbook was to differentiate these it would need to use the variable's |
If a reduction method selector in the cookbook defaulted to |
On further investigation it seems that |
This is an existing cookbook issue - see COSIMA/cosima-cookbook#212 and COSIMA/cosima-cookbook#214 |
I didn't know about the methods keyword arg in getvar! Also didn't notice that this was a duplicate of another issue. Sorry 😔 |
No worries, I'm glad you raised it as I'd forgotten about that issue. |
Oh I see, that was a suggestion of yours... :) |
Closed by COSIMA/cosima-cookbook#255 |
I noticed that
u²
is saved as a netcdf file with a variable name (inside the netcdf)u
.This creates issues when loading variables via the
cosima-cookbook
, e.g.,will load both
u
andu²
or a random combination of the two!See, e.g., output in
and
Could we fix/change the
u²
netcdf variable to beusquare
or something else other thanu
?(Yes, the problem can be alleviated by providing an
ncfile=...
argument tocosima_cookbook.querying.getvar()
but that's a hack. Also this is not what the data explorer would suggest you to do so nobody would initially think that such thing is necessary.)cc @dhruvbhagtani2105, @aidanheerdegen, @angus-g, @aekiss, @rmholmes, @AndyHoggANU
The text was updated successfully, but these errors were encountered: