Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Serialisation of float values #219

Merged
merged 2 commits into from
May 17, 2024
Merged

fix: Serialisation of float values #219

merged 2 commits into from
May 17, 2024

Conversation

mark-koch
Copy link
Collaborator

Fixes #218

@mark-koch mark-koch requested a review from qartik May 17, 2024 13:23
Copy link
Member

@qartik qartik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work with get_custom_value()

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.57%. Comparing base (7ad3908) to head (9833df5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   90.56%   90.57%           
=======================================
  Files          43       43           
  Lines        4622     4624    +2     
=======================================
+ Hits         4186     4188    +2     
  Misses        436      436           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mark-koch mark-koch merged commit 937260a into main May 17, 2024
3 checks passed
@mark-koch mark-koch deleted the fix/float-value branch May 17, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Float value serialisation is broken
3 participants