Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Serialisation of bool values #239

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix: Serialisation of bool values #239

merged 1 commit into from
Jun 12, 2024

Conversation

mark-koch
Copy link
Collaborator

Closes #238

@mark-koch mark-koch requested a review from doug-q June 12, 2024 10:31
doug-q
doug-q approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks great. I looked for other callers of SumValue and saw none.

@mark-koch mark-koch merged commit 16a77db into main Jun 12, 2024
3 checks passed
@mark-koch mark-koch deleted the fix/unit-sum-value branch June 12, 2024 11:15
@hugrbot hugrbot mentioned this pull request Jun 12, 2024
Merged
@hugrbot hugrbot mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doug-q doug-q doug-q approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: guppy generates "invalid" Hugr for constants
2 participants
@mark-koch @doug-q