Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use correct hook for error printing inside jupyter notebooks #324

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

mark-koch
Copy link
Collaborator

Fixes #323

@mark-koch mark-koch requested a review from a team as a code owner July 24, 2024 16:44
@mark-koch mark-koch requested a review from qartik July 24, 2024 16:44
@mark-koch mark-koch force-pushed the fix/jupyter-errors branch from f6210b0 to 6f00821 Compare July 24, 2024 16:45
@mark-koch mark-koch force-pushed the fix/jupyter-errors branch from 6f00821 to 66b0d75 Compare July 24, 2024 16:50
Copy link
Member

@qartik qartik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much experience with jupyter notebooks, looks okay on reading the code. Please request review from a Jupyter expert if needed.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.58%. Comparing base (6698b75) to head (66b0d75).

Files Patch % Lines
guppylang/error.py 58.33% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
- Coverage   92.67%   92.58%   -0.09%     
==========================================
  Files          45       45              
  Lines        5105     5113       +8     
==========================================
+ Hits         4731     4734       +3     
- Misses        374      379       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mark-koch mark-koch added this pull request to the merge queue Jul 25, 2024
Merged via the queue into main with commit bfdb003 Jul 25, 2024
3 checks passed
@mark-koch mark-koch deleted the fix/jupyter-errors branch July 25, 2024 08:19
github-merge-queue bot pushed a commit that referenced this pull request Jul 25, 2024
🤖 I have created a release *beep* *boop*
---


## [0.7.0](v0.6.2...v0.7.0)
(2024-07-25)


### ⚠ BREAKING CHANGES

* `qubit`s are now reset on allocation

### Features

* `qubit`s are now reset on allocation, and `dirty_qubit` added
([#325](#325))
([4a9e205](4a9e205))
* Allow access to struct fields and mutation of linear ones
([#295](#295))
([6698b75](6698b75)),
closes [#293](#293)
* Allow redefinition of names in guppy modules
([#326](#326))
([314409c](314409c)),
closes [#307](#307)


### Bug Fixes

* Use correct hook for error printing inside jupyter notebooks
([#324](#324))
([bfdb003](bfdb003)),
closes [#323](#323)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix error printing in Jupyter notebooks
3 participants