Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mem_swap function for swapping two inout values #653

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Nov 15, 2024

not sure if prelude is best place for the custom compiler

also not sure about name mem_swap but don't want to confuse with quantum logic swap

...And not sure about the test location either.

Closes #652

// to coerce release-please:

Release-As: 0.13.1

@ss2165 ss2165 requested a review from a team as a code owner November 15, 2024 12:19
@ss2165 ss2165 requested review from doug-q and mark-koch and removed request for doug-q November 15, 2024 12:19
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.49%. Comparing base (8d8c8b1) to head (bce8de8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
+ Coverage   92.48%   92.49%   +0.01%     
==========================================
  Files          66       66              
  Lines        7492     7503      +11     
==========================================
+ Hits         6929     6940      +11     
  Misses        563      563              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mark-koch mark-koch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think putting it in prelude.py is ok, the name also sounds good 👍

@ss2165 ss2165 added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit 89e10a5 Nov 15, 2024
5 checks passed
@ss2165 ss2165 deleted the ss/swap branch November 15, 2024 13:29
github-merge-queue bot pushed a commit that referenced this pull request Nov 15, 2024
🤖 I have created a release *beep* *boop*
---


## [0.13.1](v0.13.0...v0.13.1)
(2024-11-15)


### Features

* Generic function definitions
([#618](#618))
([7519b90](7519b90)),
closes [#522](#522)
* mem_swap function for swapping two inout values
([#653](#653))
([89e10a5](89e10a5))


### Bug Fixes

* Fix generic array functions
([#630](#630))
([f4e5655](f4e5655))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

builtin function for swapping two inout arguments
3 participants