Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use delocate 0.10.x when building pytket wheels on macos-13-xlarge #1342

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

cqc-alec
Copy link
Collaborator

@cqc-alec cqc-alec commented Apr 15, 2024

Description

Ensure we use a version of delocate that does not rename the wheel.

I have checked that the wheels produced do have macosx_12_0_arm64 in their name.

We should also investigate whether there really is a compatibility issue here, as delocate 0.11 would seem to indicate. I'll raise a new issue for that (and if possible reverting this change).

Related issues

Fixes #1341 .

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@cqc-alec cqc-alec marked this pull request as ready for review April 15, 2024 11:04
@cqc-alec cqc-alec requested a review from yao-cqc April 15, 2024 11:04
@cqc-alec cqc-alec merged commit 73c601d into develop Apr 15, 2024
27 checks passed
@cqc-alec cqc-alec deleted the bugfix/macos-wheel-name branch April 15, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MacOS arm64 wheels incompatible with earlier MacOS versions
2 participants