Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to override installing the raven-hydro dependency #371

Closed
Zeitsperre opened this issue May 31, 2024 · 4 comments · Fixed by #372
Closed

Allow users to override installing the raven-hydro dependency #371

Zeitsperre opened this issue May 31, 2024 · 4 comments · Fixed by #372
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@Zeitsperre
Copy link
Member

The way that the requirements work right now, we absolutely need raven-hydro to be installed (either from PyPI/pip or via conda). Perhaps there could be a low-effort and safe approach to override this requirement for some special cases?

@Zeitsperre Zeitsperre added the dependencies Pull requests that update a dependency file label May 31, 2024
@Zeitsperre Zeitsperre self-assigned this May 31, 2024
@Zeitsperre
Copy link
Member Author

@julemai The issue is this line right here:

from raven_hydro import __raven_version__
We need the package installed to get the version string. I can maybe propose a fix this morning, but I don't have time to release something just yet.

@julemai
Copy link
Collaborator

julemai commented May 31, 2024

Ahhhh. That makes sense. No worries regarding releasing anything right now. I'm happy to test it in case you do at one point.

@huard
Copy link
Collaborator

huard commented May 31, 2024

I'd be ok to just set the version string to "-" when the user provides her own executable.

@huard
Copy link
Collaborator

huard commented May 31, 2024

The offending line is in the tests, so I suspect that the code "should" work even if one test breaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants