-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to override installing the raven-hydro
dependency
#371
Labels
dependencies
Pull requests that update a dependency file
Comments
@julemai The issue is this line right here: RavenPy/tests/test_emulators.py Line 7 in dbe5fbe
|
Ahhhh. That makes sense. No worries regarding releasing anything right now. I'm happy to test it in case you do at one point. |
I'd be ok to just set the version string to "-" when the user provides her own executable. |
The offending line is in the tests, so I suspect that the code "should" work even if one test breaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The way that the requirements work right now, we absolutely need
raven-hydro
to be installed (either from PyPI/pip
or viaconda
). Perhaps there could be a low-effort and safe approach to override this requirement for some special cases?The text was updated successfully, but these errors were encountered: