Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is variable frame rate essential for quality? #8

Open
lmaxwell opened this issue Jan 20, 2018 · 3 comments
Open

Is variable frame rate essential for quality? #8

lmaxwell opened this issue Jan 20, 2018 · 3 comments

Comments

@lmaxwell
Copy link

To my understanding, magphase vocoder can also use fixed frame rate. I guess the advantage of using variable frame rate is computational efficiency and quality. If my understanding is correct, I'm
interested in which benefits more. Because If fixed frame rate can be used, it is easier to integrate the vocoder into any existing TTS frameworks.

@felipeespic
Copy link
Member

Hi @lmaxwell , I am sorry for the delay on replying.

At the beginning, when I started MagPhase, I did some experiments using constant frame rate (by interpolating the variable frame rate features), which didn't achieve comparable quality with the variable frame rate version. However, right now I am working on making a high quality interpolator to convert from variable to constant frame rate (and vice versa), which seems to deliver the same quality. So, I will push the constant frame rate version of MagPhase soon.

Thanks for the comment.

@lmaxwell
Copy link
Author

lmaxwell commented Feb 7, 2018

that's awesome, I'll try it in my work

@felipeespic
Copy link
Member

felipeespic commented Apr 23, 2018

Hi, I just pushed the constant frame version (v2.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants