Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Google Authentication #97

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Added Google Authentication #97

merged 2 commits into from
Apr 28, 2022

Conversation

Abh1shekSingh
Copy link
Contributor

Explanation

I have successfully established Google Authentication .
and fixed issue number #96

Type of Change:

  • Code

Checklist

  • The PR title starts with "Fix I will Add Google authentication #96 : "followed by a short, clear summary of the changes. ( If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...")
  • The PR explanation includes the words "Fixes I will Add Google authentication #96 : ..." ( or "Fixes part of #bugnum" if the PR only partially fixes an issue ).
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR does not break any part of the existing code.
  • The PR creator have carefully read & adhere to the contributing guidelines of the project.
  • The PR is raised for an issue that has been assigned to you.
  • The PR is made to the branch that's called "develop".
  • The PR is raised from a branch that is up-to-date with "develop".

@Abh1shekSingh
Copy link
Contributor Author

Please Review the PR.

@Abh1shekSingh
Copy link
Contributor Author

Abh1shekSingh commented Apr 28, 2022 •
edited
Loading

@riturajjain2000 Once this get approved then only it will be possible to work on other issue for me. Please review

@riturajjain2000 riturajjain2000 merged commit 968a645 into CSwala:develop Apr 28, 2022
riturajjain2000 added a commit that referenced this pull request Apr 28, 2022
@riturajjain2000
Revert "Added Google Authentication (#97)"
c70601a 
This reverts commit 968a645.
@riturajjain2000 riturajjain2000 mentioned this pull request Apr 28, 2022
Merged
riturajjain2000 added a commit that referenced this pull request Apr 28, 2022
@riturajjain2000
Revert "Added Google Authentication (#97)" (#99)
2bcc196 
This reverts commit 968a645.
@riturajjain2000
Copy link
Member

This PR broke the explore page , also the buttons for google and GitHub needs to be fixed , they beacame blue in color
Screenshot 2022-04-28 162547

@Abh1shekSingh
Copy link
Contributor Author

Abh1shekSingh commented Apr 28, 2022 •
edited
Loading

This PR broke the explore page , also the buttons for google and GitHub needs to be fixed , they beacame blue in color Screenshot 2022-04-28 162547

The PR doesn't broke the explore page bro. First you need to login. Once you get logged in, then you can see the explore page. I added this functionality. I will make button responsive no worries.

@riturajjain2000
Copy link
Member

Ok , so revert back , we don't want users to login first , not for the explore page at least , also after clicking on the sign-in buttons , the google account dialog should open , to choose from different account , which is also not happening

@Abh1shekSingh
Copy link
Contributor Author

Ok , so revert back , we don't want users to login first , not for the explore page at least , also after clicking on the sign-in buttons , the google account dialog should open , to choose from different account , which is also not happening

Okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riturajjain2000 riturajjain2000 riturajjain2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I will Add Google authentication
2 participants
@Abh1shekSingh @riturajjain2000