Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJS pattern for Stream Reader #4

Open
jayachandranm opened this issue Apr 24, 2017 · 2 comments
Open

NodeJS pattern for Stream Reader #4

jayachandranm opened this issue Apr 24, 2017 · 2 comments

Comments

@jayachandranm
Copy link

Thanks for this module!

Probably your pattern for creating the stream from dynamodb scan results can be improved. Instead of pumping data to the streamer object, if the streamer object itself does the scan operation, the use of the variable as an intermediary could be avoided.

Here is an example,
https://calv.info/an-introduction-to-nodes-new-streams

@sbower
Copy link
Member

sbower commented Apr 26, 2017

If you are interested please feel free to fork and submit a PR

@jayachandranm
Copy link
Author

I will give a try! I am not an experienced user of nodejs, but I got a working version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants