Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates: add "overrides" folder, split head/foot sections of html.html.twig into head/foot templates #13

Closed
4 tasks done
alisonjo315 opened this issue Jan 17, 2021 · 1 comment · Fixed by #21
Closed
4 tasks done
Labels
enhancement New feature or request

Comments

@alisonjo315
Copy link
Collaborator

alisonjo315 commented Jan 17, 2021

  • Rename "shared" to "overrides"
    • No these words don't mean the same thing, that's ok -- "shared" is less specific anyway (partial templates can be shared), and I think at this point we prefer a folder called "overrides" and a folder called either "partials" or "includes," ya?
    • The only template in "shared" right now is a field template for field_post_date, so that fits for an "overrides" folder.
  • Create "partials" folder
  • Split head/foot sections of html.html.twig into head/foot templates (just b/c we do this in child themes kinda every time anyway, right?)
    • i.e. site-header, site-footer, cu-header, cu-search
  • Document intended use of "overrides" and "partials" sub-folders.

⚠️ UPDATE: Footer template will have to wait, because cwd_base puts footer stuff in page.html.twig, so we can't put it "in" html.html.twig (by way of site-footer.html.twig).

@alisonjo315
Copy link
Collaborator Author

(wait til after #11)

@alisonjo315 alisonjo315 added the enhancement New feature or request label Jan 17, 2021
@alisonjo315 alisonjo315 changed the title Split head/foot sections of html.html.twig into head/foot templates Templates: add "overrides" folder, split head/foot sections of html.html.twig into head/foot templates Oct 20, 2021
alisonjo315 added a commit that referenced this issue Oct 20, 2021
alisonjo315 added a commit that referenced this issue Oct 20, 2021
…holer footer template and code comments

Issue #13, item 2
@alisonjo315 alisonjo315 linked a pull request Oct 27, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant