Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phoneme count bug #390

Closed
kylebgorman opened this issue Mar 23, 2021 · 1 comment · Fixed by #392
Closed

Phoneme count bug #390

kylebgorman opened this issue Mar 23, 2021 · 1 comment · Fixed by #392
Assignees
@ajmalanoski
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@kylebgorman
Copy link
Collaborator

As pointed out by @ajmalanoski in #387, the phoneme summary counter in generate_phones_summary.py is actualy counting lines, not phonemes, and we allow blank lines.
@kylebgorman kylebgorman added the enhancement New feature or request label Mar 23, 2021
@kylebgorman
Copy link
Collaborator Author

@ajmalanoski going to assign this one to you, at your leisure.

@kylebgorman kylebgorman added good first issue Good for newcomers bug Something isn't working and removed enhancement New feature or request labels Mar 24, 2021
@ajmalanoski ajmalanoski mentioned this issue Mar 25, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajmalanoski ajmalanoski

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes phone counting in data/src/generate_phones_summary.py ajmalanoski/wikipron
2 participants
@kylebgorman @ajmalanoski