Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dime_socket_t send/recv optimizations #5

Open
TheHashTableSlasher opened this issue May 18, 2020 · 0 comments
Open

dime_socket_t send/recv optimizations #5

TheHashTableSlasher opened this issue May 18, 2020 · 0 comments
Labels
low priority Other things should be worked on first optimization Improvements to code quality or efficiency server Relates to the server code

Comments

@TheHashTableSlasher
Copy link
Collaborator

A few things:

  • Buffers for send/recv are allocated dynamically. A static byte array might make more sense if we can ensure a single-threaded, non-reentrant server
  • We can skip a potentially expensive memcpy and read directly from the buffer if the contents therein are contiguous
  • The ring buffers can be shrunk when they are empty
@TheHashTableSlasher TheHashTableSlasher added optimization Improvements to code quality or efficiency server Relates to the server code labels May 18, 2020
@TheHashTableSlasher TheHashTableSlasher added the low priority Other things should be worked on first label Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low priority Other things should be worked on first optimization Improvements to code quality or efficiency server Relates to the server code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TheHashTableSlasher