Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid January 1 failures of CVE ID reservation #577

Closed
ElectricNroff opened this issue Mar 14, 2022 · 2 comments
Closed

avoid January 1 failures of CVE ID reservation #577

ElectricNroff opened this issue Mar 14, 2022 · 2 comments
Assignees

Comments

@ElectricNroff
Copy link
Contributor

(This does not need to be addressed for the initial production release of CVE Services 2.x.)

logger.info({ uuid: req.ctx.uuid, message: 'CVE IDs for year ' + year + ' cannot be reserved at this time.' })

logger.info({ uuid: req.ctx.uuid, message: 'CVE IDs for year ' + year + ' cannot be reserved at this time.' })

logger.info({ uuid: req.ctx.uuid, message: 'CVE IDs for year ' + year + ' cannot be reserved at this time.' })

cause CVE ID reservations to start failing each January 1 unless a client user has remembered to do annual maintenance tasks such as
await cveIdRangeRepo.findOneAndUpdate({ cve_year: year }, defaultDoc, { upsert: true })
const payload = {
action: 'create_cveIdRange',
change: 'CVE Id Range document for year ' + year + ' was created.',

A more reasonable design would have:

  • the code is able to calculate usable range values for all future years
  • the code is able to enforce a policy on how early a range may be used (e.g., in October 2022, one cannot reserve CVE-2525-#### but CVE-2023-#### is OK)
  • if perspectives on usable range values change, the code should be updated before January 1, and a new release deployed to production before January 1
@jdaigneau5 jdaigneau5 added the Moderate 5-20 Hours label Apr 4, 2022
@shelbyc
Copy link

shelbyc commented Oct 6, 2023

If there are any items that should be prioritized in Q4 2023, I think it should be this one. January 1 is approaching, and people likely don't want to deal with errors as their first item coming back from the holidays.

@jdaigneau5 jdaigneau5 added Needs Discussion and removed Moderate 5-20 Hours labels Mar 7, 2024
@jdaigneau5 jdaigneau5 moved this to To do in Sprint 44 Jul 2, 2024
@jdaigneau5 jdaigneau5 moved this to High Priority in Issue Triage Jul 2, 2024
@jdaigneau5 jdaigneau5 moved this from To do to In progress in Sprint 44 Jul 8, 2024
@jdaigneau5 jdaigneau5 removed this from Sprint 44 Jul 8, 2024
@mprpic
Copy link
Contributor

mprpic commented Jul 30, 2024

Discussion from AWG meeting on Jul 30, 2024: how many days ahead of a new year should CVE Services automatically allow reservation of IDs for the next year? Currently enabling the next year is a manual action that is not consistently done at a set date. At the same time, we don't want to allow reservations for arbitrary future years since it could be misused to reserve IDs for e.g. year 2050, and dilutes the value of the year part in the identifier. Reserving IDs ahead of the new year is a legitimate use case for some CNA so we also can't restrict reservations to only the current year exclusively.

The proposed and agreed solution: automatically allow reservations 90 days ahead of the next year.

@david-rocca david-rocca moved this from In Review to Done in Sprint 45 Dec 30, 2024
@david-rocca david-rocca closed this as completed by moving to Done in Sprint 45 Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

5 participants