New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error checking in put / get statements #13

Open

mnlevy1981 opened this issue Feb 9, 2014 · 0 comments

Assignees

Labels

Milestone

First public release

Contributor

mnlevy1981 commented Feb 9, 2014

We should make sure the shape of any arrays being stored via cvmix_put are the same shape as the data type attribute they are being stored in.

Example:

This is good, because zt should be size nlev

allocate(depth(5))
cvmix_put(CVMix_vars, 'nlev', 5)
cvmix_put(CVMix_vars, 'zt', depth)

This is bad, but results in a seg-fault instead of a clean error

allocate(depth(8))
cvmix_put(CVMix_vars, 'nlev', 5)
cvmix_put(CVMix_vars, 'zt', depth)

This is also bad, and I think will also seg-fault... at the very least it will do something unexpected

allocate(depth(5))
cvmix_put(CVMix_vars, 'nlev', 8)
cvmix_put(CVMix_vars, 'zt', depth)

mnlevy1981 added this to the First public release milestone

mnlevy1981 added the enhancement label

mnlevy1981 self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment