Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved compatibility checks with to_/from_yaml #186

Open
dafyddstephenson opened this issue Oct 30, 2024 · 0 comments
Open

Improved compatibility checks with to_/from_yaml #186

dafyddstephenson opened this issue Oct 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@dafyddstephenson
Copy link
Collaborator

Currently, roms-tools warns about any version mismatch between the version recorded in the yaml file and the current version of roms-tools, even if the resulting datasets do not change between versions.

I propose we

  • Keep the current system for all versions below 1.6.0 (or whatever version is current when this gets addressed)
  • Going forward, use pytest to create a series of netCDF files from a chosen set of yaml files and compare their hashes against a known manifest. If there is a mismatch between the most recent hashes recorded in the manifest (i.e. it has not been updated), the test should fail.
  • Use this manifest internally to determine whether the user's version is truly incompatible with the current version before issuing the warning.

@NoraLoose what do you think?

@dafyddstephenson dafyddstephenson added the enhancement New feature or request label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant