Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot send message with String value #17

Closed
mjhouse opened this issue Dec 25, 2021 · 4 comments
Closed

Cannot send message with String value #17

mjhouse opened this issue Dec 25, 2021 · 4 comments

Comments

@mjhouse
Copy link

mjhouse commented Dec 25, 2021

I'm unable to receive messages through bevy_spicy_networking that contain strings- I've sent and received empty messages and messages with u8 values, and so far this issue only occurs with string messages (video).

See this issue that I submitted to erased-serde for error messages etc. I'm not sure if I've done something wrong, if this is an issue with bevy_spicy_networking or erased-serde.

If it's a bug it seems like a bad one. You can clone and build warfare-rs (at this commit) if you need to reproduce. The messages are defined in networking/messages.rs, and the actual send/receive code is in systems/network.rs.

(there are some dependencies to build warfare, check the readme)

@TheNeikos
Copy link
Contributor

Huh, that is not intended of course!

pub message: String,

The examples actually have something quite similar in them, could you try those out on your machine?

@mjhouse
Copy link
Author

mjhouse commented Dec 26, 2021

@TheNeikos Huh, that's weird. The example works.

@mjhouse
Copy link
Author

mjhouse commented Dec 26, 2021

Whatever the issue was, it appears to be resolved in erased-serde 0.3.17. I can't reproduce with that version.

@TheNeikos
Copy link
Contributor

Alright, great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants