Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no sufficient document for Sketch's arc function. #1663

Open
huskier opened this issue Sep 8, 2024 · 0 comments
Open

There is no sufficient document for Sketch's arc function. #1663

huskier opened this issue Sep 8, 2024 · 0 comments
Labels

Comments

@huskier
Copy link
Contributor

huskier commented Sep 8, 2024

In the current master, there is no sufficient document for Sketch's arc function, especially for the overload function of

    @arc.register
    def arc(
        self: T,
        c: Point,
        r: Real,
        a: Real,
        da: Real,
        tag: Optional[str] = None,
        forConstruction: bool = False,
    ) -> T:

Maybe variable "a" and variable "da" should be given more cares.

From the source code, I guess "a" should be the start angle, and "da" should be the angle value with direction included. If the arc is toward CW, the "da" should be negtive. Otherwise, the "da" should be positive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants