cadquery.Workplane.rarray arg handling implemented incorrectly.

[JosiahBradley]

cadquery/cadquery/cq.py

Line 1294 in 2d721d0

if xSpacing < 1 or ySpacing < 1 or xCount < 1 or yCount < 1:

According to https://cadquery.readthedocs.io/en/latest/classreference.html#cadquery.Workplane.rarray
rarray's arguments need to be greater than 0. The implementation correctly does this for the integer arguments xCount and yCount, however xSpacing and ySpacing are floats and their check should be if arg less than or equal to 0
This simple code reproduces the error:

import cadquery as cq
cq.Workplane().box(5.0, 5.0, 5.0).faces(">Z").rarray(1.0, 0.625, 1, 3).hole(0.125)

Recommended Solution

if xSpacing <= 0 or ySpacing <= 0 or xCount < 1 or yCount < 1:
            raise ValueError("Spacing and count must be > 0 ")

[jmwright]

@JosiahBradley Good catch. Would you be interested in creating a PR for this?