Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sketch Angle, ArcAngle constraints are reversed #959

Open
lorenzncode opened this issue Jan 15, 2022 · 1 comment
Open

Sketch Angle, ArcAngle constraints are reversed #959

lorenzncode opened this issue Jan 15, 2022 · 1 comment

Comments

@lorenzncode
Copy link
Member

I find ArcAngle results are in the reversed sense.

For example, the results of the following Sketch with or without solve is expected to be the same.

s = (
    cq.Sketch()
    .arc((0,0), 1, 30, 120, "arc1")
    .constrain("arc1", "FixedPoint", 0)
    .constrain("arc1", "ArcAngle", 120)
    #.solve()
)

Without solve:
image

With solve (not expected):
image

Angle constraint is likewise reversed. I'll plan to open a PR shortly.

@adam-urbanczyk
Copy link
Member

Thanks for checking! Constraint itself looks OK, but It might be the translation from the solver DOFs to cq.Edge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants