Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPS Spikes #519

Open
Squidistry opened this issue Jun 15, 2024 · 4 comments
Open

TPS Spikes #519

Squidistry opened this issue Jun 15, 2024 · 4 comments
Labels
S-cannot-repro Status: Developer can't reproduce T-bug Type: Bug

Comments

@Squidistry
Copy link


Version Information

lithium-fabric-mc1.20.1-0.11.2
Causing tps spikes above 1300

Actual Behavior

Caused tps to spike

Reproduction Steps

Install Lithium

Other Information

https://spark.lucko.me/1blXmWAwU1
PalettedContainer.serialize() causing it to spike

@Squidistry Squidistry added the T-bug Type: Bug label Jun 15, 2024
@2No2Name
Copy link
Member

Maybe try adding the line
mixin.chunk.serialization=false
to the lithium.properties in the config folder and test again

@2No2Name 2No2Name added the S-cannot-repro Status: Developer can't reproduce label Jun 18, 2024
@Libreh
Copy link

Libreh commented Jul 30, 2024

I had the same TPS spike yesterday on 1.21, it too got down to PalettedContainer.serialize(), it's hard to re-produce since it appears to only occur for me after an hour or two (or a lot of chunk loading).

@jellysquid3
Copy link
Member

It is worth mentioning that chunk serialization is slow and the time it takes depends on how complex the chunks are. That means, if they have more mobs or block entities, the server will need more time to save them. And the more chunks the server is waiting on to save, the longer the spikes will become as it tries to work through the backlog.

@Libreh
Copy link

Libreh commented Aug 2, 2024

I don't remember getting this before 1.21 though, it's weird.
I remember playing 1.20.4 with 20 chunks just like I do now and I wouldn't get this.
It still happens with mixin.chunk.serialization=false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-cannot-repro Status: Developer can't reproduce T-bug Type: Bug
Projects
None yet
Development

No branches or pull requests

4 participants