Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powder snow face culling may be excessive #1163

Closed
muzikbike opened this issue Feb 3, 2022 · 1 comment
Closed

Powder snow face culling may be excessive #1163

muzikbike opened this issue Feb 3, 2022 · 1 comment
Labels
A-vanilla-parity Area: Vanilla parity T-bug Type: Bug
Milestone

Comments

@muzikbike
Copy link
Contributor

Version information

sodium-fabric-mc1.17.1-0.3.4+build.13

Expected Behavior

Only the outer faces of powder snow would be culled by solid blocks - the inner faces would not be, and would only be able to be culled by other powder snow blocks.

Actual Behavior

The inner faces of powder snow are still culled against solid block faces, which goes against expected and vanilla behaviour.

Reproduction Steps

  1. Obtain powder snow
  2. Place the powder snow such that it contacts a solid block face, and that this solid block face is visible from inside the powder snow
  3. Enter the powder snow

Java version

16.0.2 64-bit

CPU

4× Intel® Core™ i3-3240 CPU @ 3.40GHz

GPU

Intel® HD Graphics 2500

Additional information

This results from the fix to #859, and has advantages and disadvantages; it gets rid of some Z-fighting issues, however this new behaviour differs substantially from vanilla in a way I'm not sure is desirable.
2022-02-03_11 24 48

One important thing to note is that it ends up exposing the non-tinted snowy grass block top, which should never be visible in normal survival:
2022-02-03_11 25 17

@jellysquid3
Copy link
Member

Resolved with c937156.

@jellysquid3 jellysquid3 added the R-pending-release Resolution: Pending release label Jan 27, 2024
@jellysquid3 jellysquid3 added this to the Sodium 0.5.6 milestone Jan 27, 2024
@jellysquid3 jellysquid3 removed the R-pending-release Resolution: Pending release label Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-vanilla-parity Area: Vanilla parity T-bug Type: Bug
Projects
None yet
Development

No branches or pull requests

3 participants