Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoadingProvider throws away entire widget tree #16

Open
DreadBoy opened this issue Nov 30, 2020 · 0 comments
Open

LoadingProvider throws away entire widget tree #16

DreadBoy opened this issue Nov 30, 2020 · 0 comments

Comments

@DreadBoy
Copy link

Including provider this way:

MaterialApp(
  builder: (context, widget) {
    return LoadingProvider(
      child: widget,
    );
  },
);

throws away entire widget tree inside LoadingProvider if anything above changes, for example EasyLocalization locale or some other provider. This is performance problem. Rebuilding widget tree is fine, throwing it away by changing widget key and rebuilding it is wasteful. Is this intentional behaviour or bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant