-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in the Hooper method for conical diffuser/expansion #60
Comments
Hi Allan, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Dear Caleb,
It is a great tool that you have developed!
I am currently working with the Hooper method for a conical diffuser/expansion from the fluids.fittings library. I think there is a small error for the case of Re_1 < 4000 and angle < 45°. It returns K = K_sharp while it should return K = K_sharp2.6sin(angle/2).
Code is stated below:
elif method == 'Hooper':
if Re is None:
raise ValueError("Method
Hooper
requires Reynolds number")if Re < 4000.0:
return 2.0*(1.0 - betabetabetabeta) # Not the same formula as Rennels
if fd is None:
fd = Clamond(Re=Re, eD=roughness/Di1)
x = 1.0 - betabeta
K = (1.0 + 0.8fd)xx
if angle_rad > 0.25pi:
return K
return K2.6sin(0.5*angle_rad)
Best regards,
Allan
The text was updated successfully, but these errors were encountered: