Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precomputing the majorant + unionised grids with S(alpha,beta) #28

Closed
ChasingNeutrons opened this issue Feb 15, 2023 · 1 comment
Closed

Precomputing the majorant + unionised grids with S(alpha,beta) #28

ChasingNeutrons opened this issue Feb 15, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@ChasingNeutrons
Copy link
Collaborator

At the moment, by default SCONE does not precompute the majorant when using delta tracking. This will hamstring delta tracking performance in problems with many materials/nuclides. One way of doing this is to use unionised grids (through using aceNeutronDatabaseUni). This has two problems: for problems with lots of nuclides present this will also become inefficient and it also currently does not work when S(alpha,beta) is turned on.

I suppose the ideal fix would be having a nice option for general majorant precomputation. I'd like to try and work on this when I get some time but I'm happy for anyone else to dive in.
@ChasingNeutrons ChasingNeutrons added the enhancement New feature or request label Feb 15, 2023
@valeriaRaffuzzi
Copy link
Member

Solved with PR #106.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChasingNeutrons @valeriaRaffuzzi