Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omitting a test that can randomly fail #11

Open
pgrt opened this issue Nov 28, 2021 · 0 comments
Open

Omitting a test that can randomly fail #11

pgrt opened this issue Nov 28, 2021 · 0 comments

Comments

@pgrt
Copy link

pgrt commented Nov 28, 2021

Hello,

The test testRemoveThresholdingEffectArtifact in goby-distribution/src/test/java/org/campagnelab/goby/modes/TestDiscoverSequenceVariantsMode.java may fail as it calls qualityScoreFilter.filterGenotypes, which depends on the output of a random variable generator.

As you fix the seed (as the result of some deterministic computation), the output of the test will always be the same. But if the inputs of the seed computation change for whatever reason, the test may begin always failing. I met this issue when building goby3 against a newer version of picard. I changed the seed manually to be 1 and the test passed, thus confirming the seed choice can be an issue.

I have deactivated the test during the Debian build.

Bye,
Pierre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant