fix(build): fix dependencies of core package

Author: oscar60310

packages/build/src/containers/container.ts

@@ -10,9 +10,9 @@ export class Container {
     return this.inversifyContainer.get<T>(type);
   }
 
-  public load(options: IBuildOptions) {
+  public async load(options: IBuildOptions) {
     const coreContainer = new CoreContainer();
-    coreContainer.load(options);
+    await coreContainer.load(options);
     this.inversifyContainer.parent = coreContainer.getInversifyContainer();
     this.inversifyContainer.load(schemaParserModule(options.schemaParser));
   }

packages/build/src/lib/schema-parser/middleware/addMissingErrors.ts

@@ -1,6 +1,12 @@
 import { AllTemplateMetadata, APISchema } from '@vulcan/core';
 import { SchemaParserMiddleware } from './middleware';
 
+interface ErrorCode {
+  code: string;
+  lineNo: number;
+  columnNo: number;
+}
+
 // Add error code to definition if it is used in query but not defined in schema
 export const addMissingErrors =
   (allMetadata: AllTemplateMetadata): SchemaParserMiddleware =>
@@ -10,9 +16,10 @@ export const addMissingErrors =
     const templateName = transformedSchemas.templateSource;
     const metadata = allMetadata[templateName];
     // Skip validation if no metadata found
-    if (!metadata?.errors) return;
+    if (!metadata?.['error.vulcan.com']) return;
 
-    metadata.errors.forEach((error) => {
+    const errorCodes: ErrorCode[] = metadata['error.vulcan.com'].errorCodes;
+    errorCodes.forEach((error) => {
       if (!transformedSchemas.errors.some((e) => e.code === error.code)) {
         transformedSchemas.errors.push({
           code: error.code,

packages/build/src/lib/schema-parser/middleware/checkParameter.ts

@@ -1,6 +1,12 @@
 import { AllTemplateMetadata, APISchema } from '@vulcan/core';
 import { SchemaParserMiddleware } from './middleware';
 
+interface Parameter {
+  name: string;
+  lineNo: number;
+  columnNo: number;
+}
+
 export const checkParameter =
   (allMetadata: AllTemplateMetadata): SchemaParserMiddleware =>
   async (schemas, next) => {
@@ -9,9 +15,9 @@ export const checkParameter =
     const templateName = transformedSchemas.templateSource;
     const metadata = allMetadata[templateName];
     // Skip validation if no metadata found
-    if (!metadata?.parameters) return;
+    if (!metadata?.['parameter.vulcan.com']) return;
 
-    const parameters = metadata.parameters;
+    const parameters: Parameter[] = metadata['parameter.vulcan.com'];
     parameters.forEach((parameter) => {
       // We only check the first value of nested parameters
       const name = parameter.name.split('.')[0];

packages/build/src/lib/vulcanBuilder.ts

@@ -10,7 +10,7 @@ import {
 export class VulcanBuilder {
   public async build(options: IBuildOptions) {
     const container = new Container();
-    container.load(options);
+    await container.load(options);
     const schemaParser = container.get<SchemaParser>(TYPES.SchemaParser);
     const templateEngine = container.get<TemplateEngine>(
       CORE_TYPES.TemplateEngine

packages/build/test/schema-parser/middleware/addMissingErrors.spec.ts

@@ -12,18 +12,19 @@ it('Should add missing error codes', async () => {
   };
   const metadata: AllTemplateMetadata = {
     'some-name': {
-      parameters: [],
-      errors: [
-        {
-          code: 'ERROR 1',
-          locations: [
-            {
-              lineNo: 0,
-              columnNo: 0,
-            },
-          ],
-        },
-      ],
+      'error.vulcan.com': {
+        errorCodes: [
+          {
+            code: 'ERROR 1',
+            locations: [
+              {
+                lineNo: 0,
+                columnNo: 0,
+              },
+            ],
+          },
+        ],
+      },
     },
   };
   // Act
@@ -48,17 +49,19 @@ it('Existed error codes should be kept', async () => {
   const metadata: AllTemplateMetadata = {
     'some-name': {
       parameters: [],
-      errors: [
-        {
-          code: 'ERROR 1',
-          locations: [
-            {
-              lineNo: 0,
-              columnNo: 0,
-            },
-          ],
-        },
-      ],
+      'error.vulcan.com': {
+        errorCodes: [
+          {
+            code: 'ERROR 1',
+            locations: [
+              {
+                lineNo: 0,
+                columnNo: 0,
+              },
+            ],
+          },
+        ],
+      },
     },
   };
   // Act
@@ -82,7 +85,7 @@ it('Should tolerate empty error data', async () => {
   const metadata: object = {
     'some-name': {
       parameters: [],
-      errors: null,
+      'error.vulcan.com': null,
     },
   };
   // Act

packages/build/test/schema-parser/middleware/checkParameter.spec.ts

@@ -50,7 +50,7 @@ it(`Should throw when any parameter hasn't be defined`, async () => {
   };
   const metadata: AllTemplateMetadata = {
     'some-name': {
-      parameters: [
+      'parameter.vulcan.com': [
         {
           name: 'param1',
           locations: [],
@@ -81,7 +81,7 @@ it('Should tolerate empty parameter data', async () => {
   };
   const metadata: object = {
     'some-name': {
-      parameters: null,
+      'parameter.vulcan.com': null,
       errors: [],
     },
   };