fix(serve): add error handler for auth route middleware

Author: kokokuo

packages/serve/src/lib/middleware/auth/authRouteMiddleware.ts

@@ -98,9 +98,15 @@ export class AuthRouteMiddleware extends BuiltInMiddleware<AuthOptions> {
         return;
       }
       // type does not support
-      const result = await this.authenticators[type].authIdentity(context);
-      context.body = result;
-      return;
+      try {
+        const result = await this.authenticators[type].authIdentity(context);
+        context.body = result;
+      } catch (err) {
+        context.status = 400;
+        context.body = {
+          message: (err as Error).message,
+        };
+      }
     });
   }
 }

packages/serve/test/middlewares/built-in-middlewares/authRouteMiddleware.spec.ts

@@ -182,4 +182,30 @@ describe('Test auth route middleware', () => {
     expect(response.body).toEqual(expected);
     server.close();
   });
+
+  it('Should failed when call GET /auth?type=a3 but auth identity "a3" failed', async () => {
+    // Arrange
+    const error = new Error('please provide "token"');
+    const expected = {
+      message: error.message,
+    };
+    const stubAuthenticator = sinon.stubInterface<BaseAuthenticator<any>>();
+    stubAuthenticator.authIdentity.rejects(error);
+    stubAuthenticator.getExtensionId.returns('a3');
+    const server = await runServer(
+      { a3: {} },
+      {
+        a3: stubAuthenticator,
+      }
+    );
+
+    // Act
+    const request = supertest(server).get(`/auth?type=a3`);
+    const response = await request;
+
+    // Assert
+    expect(response.statusCode).toEqual(400);
+    expect(response.body).toEqual(expected);
+    server.close();
+  });
 });