Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show additional info (crate and or duration) in test titles #218

Open
Canop opened this issue Oct 1, 2024 · 4 comments
Open

Show additional info (crate and or duration) in test titles #218

Canop opened this issue Oct 1, 2024 · 4 comments

Comments

@Canop
Copy link
Owner

Canop commented Oct 1, 2024

Rationale for showing the crate given here by @DragonDev1906.

The duration would be only available when it can be parsed from the output (i.e. when the tests are done with nextest).

The reason I'm a little reluctant is I try to keep the display uncluterred for easier reading, and I try to make bacon usable in a thin terminal.

Opinions welcome.

@DragonDev1906
Copy link

and I try to make bacon usable in a thin terminal.

Good point with the thin terminal. How difficult would it be to only show this extra information (crate + time) if the terminal is wide enough? That way you could temporarily full-screen the terminal and get more information.

@Canop
Copy link
Owner Author

Canop commented Oct 1, 2024

This wouldn't be terribly hard, I do this kind of auto-ellipsis all the time in eg broot.

But this kind of collides wit the wrapping feature: what if people start to want the crate, duration even when it means the line is wrapped?

@Canop
Copy link
Owner Author

Canop commented Oct 1, 2024

I made it a separate issue because I'll try to merge the PR #212 so that I can more easily manage various small issues.

@DragonDev1906
Copy link

But this kind of collides wit the wrapping feature: what if people start to want the crate, duration even when it means the line is wrapped?

I doubt that's the case, as at that point the rest of the issue description gets difficult enough to read that you probably don't want even more information. Unless you have really long module names/import paths, so perhaps having it configurable does make sense.

2024-10-01-180014_496x321_scrot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants