Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bacon gets confused when the build command has unexpected output #24

Closed
jyn514 opened this issue Nov 17, 2020 · 4 comments
Closed

Bacon gets confused when the build command has unexpected output #24

jyn514 opened this issue Nov 17, 2020 · 4 comments

Comments

@jyn514
Copy link
Contributor

jyn514 commented Nov 17, 2020

This is a screenshot of bacon after saving a modified file, after bacon starts up for the first time.

image

I would expect the extra output to be either hidden or shown with proper line wrapping, not with weird indentation.

You can reproduce by running bacon on rustc (rustc strikes again!) with the following bacon.toml:

default_job = "check"

[jobs]

[jobs.check]
command = ["x", "check", "--color", "always"]

[jobs.clippy]
command = ["x", "clippy", "--color", "always"]
@Canop
Copy link
Owner

Canop commented Nov 17, 2020

Can you try with

[jobs.check]
command = ["x", "check", "--color", "always"]
need_stdout = true

I have two questions:

  • on what OS do you run this ?
  • did you change x.py to accept the color argument ? Or what's the trick ?

@jyn514
Copy link
Contributor Author

jyn514 commented Nov 17, 2020

need_stdout = true did not help. I ran this on x86_64-unknown-linux-gnu (Debian 10), although I wouldn't expect that to affect anything.

did you change x.py to accept the color argument ? Or what's the trick ?

Yes, that was rust-lang/rust#79004; you may need to update your fork of the repository.

@Canop
Copy link
Owner

Canop commented Nov 17, 2020

I don't reproduce and I don't understand how x's output can travel up to the screen.

Can you reproduce with the last commit (which pipes the command output to null) ?

@jyn514
Copy link
Contributor Author

jyn514 commented Nov 17, 2020

Works fine on latest master, thanks for the quick fix :)

@jyn514 jyn514 closed this as completed Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants