Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake examples require the /uft-8 flag on Windows if fmt is compiled with Unicode support #1742

Closed
bryanwweber opened this issue Jul 28, 2024 · 0 comments · Fixed by #1744
Closed
Assignees

Comments

@bryanwweber
Copy link
Member

bryanwweber commented Jul 28, 2024

Problem description

The PR to update the conda package to fmt-11 was failing builds because the examples on Windows, compiled with CMake, were missing the /utf-8 flag for Unicode support. The fix I landed on for the recipe was to add fmt as an external package with find_package() so that the appropriate flag was added automatically by the fmt CMake config. The patch file is located here. That patch should be ported to upstream Cantera to fix the issue.

We should also bump the CMake minimum version as part of the fix for this issue, to resolve the deprecation warning from CMake:

-- Building for: Visual Studio 17 2022
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant