Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Python 1D capabilities to C++ #186

Open
ischoegl opened this issue Aug 27, 2023 · 0 comments
Open

Port Python 1D capabilities to C++ #186

ischoegl opened this issue Aug 27, 2023 · 0 comments
Labels
feature-request New feature request

Comments

@ischoegl
Copy link
Member

Abstract

The Python 1D Flame simulation objects implement several helper functions that make the Python API significantly more user friendly than other Cantera interfaces. The user-friendly implementation makes the Python code more complex than other interfaces, where both pure Python (onedim.py) and Cython (_ondim.pyx) implementations are used.

Motivation

Describe the need for the proposed change:

  • What problem is it trying to solve? ... make 1D simulations more user friendly
  • Who is affected by the change? ... users that don't use Python
  • Why is this a good solution? ... single implementation is usable from all interfaces

Possible Solutions

Some modifications may impact only simple methods, while other simplifications may require refactoring of entire objects. A minimalist solution may just involve porting parts of FlameBase.set_initial_guess, while a maximalist solution implements FreeFlame, etc. in C++ via factory methods.

@ischoegl ischoegl added the feature-request New feature request label Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature request
Projects
None yet
Development

No branches or pull requests

1 participant