-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A third party package for sensitivity analysis of one-dimensional flame #89
Comments
Hi @jiweiqi! Thanks for opening this. This looks like a very interesting effort! Will this require any specific changes to Cantera itself? If not, I'm not sure this is the best place to post about this, the Users' Group might be a better place to advertise this. If there are changes required to Cantera, can you be more specific about them? Thanks! |
@jiweiqi ... as Bryan said this looks definitely interesting, but I share his questions about the direction of this effort. @bryanwweber ... as an alternative, per #83 this may be a candidate for ‘show-and-tell’ discussion threads. |
@ischoegl good point, it might get more exposure on the UG though |
@jiweiqi Since this isn't a proposal for an enhancement to Cantera specifically, I'm going to close it to keep the issues somewhat organized and actionable for the development team. If you'd like to shift this into a feature request for adjoint sensitivity of species in the 1-D module, in addition to the flame speed, I think that'd be more appropriate and you can feel free to edit and reopen the issue to focus around that. I see you've also commented on #71, which seems to be similar to this one. |
Delete to avoid unintentional advertising of unrelated stuffs
The text was updated successfully, but these errors were encountered: