Button and api route for uploading logs (#1221)

Brendonovich · web-flow · commit 82c3a34936f4 · 2025-10-17T16:32:19.000+08:00
* button and api route for uploading logs

* use env for webhook url

* limit to 1mb

* cleanup
diff --git a/apps/desktop/src-tauri/src/lib.rs b/apps/desktop/src-tauri/src/lib.rs
@@ -13,6 +13,7 @@ mod flags;
 mod frame_ws;
 mod general_settings;
 mod hotkeys;
+mod logging;
 mod notifications;
 mod permissions;
 mod platform;
@@ -110,24 +111,17 @@ pub enum RecordingState {
     Active(InProgressRecording),
 }
 
-#[derive(specta::Type, Serialize)]
-#[serde(rename_all = "camelCase")]
 pub struct App {
     #[deprecated = "can be removed when native camera preview is ready"]
     camera_ws_port: u16,
-    #[serde(skip)]
     camera_preview: CameraPreviewManager,
-    #[serde(skip)]
     handle: AppHandle,
-    #[serde(skip)]
     recording_state: RecordingState,
-    #[serde(skip)]
     recording_logging_handle: LoggingHandle,
-    #[serde(skip)]
     mic_feed: ActorRef<feeds::microphone::MicrophoneFeed>,
-    #[serde(skip)]
     camera_feed: ActorRef<feeds::camera::CameraFeed>,
     server_url: String,
+    logs_dir: PathBuf,
 }
 
 #[derive(specta::Type, Serialize, Deserialize, Clone, Debug)]
@@ -1938,7 +1932,7 @@ pub type DynLoggingLayer = Box<dyn tracing_subscriber::Layer<FilteredRegistry> +
 type LoggingHandle = tracing_subscriber::reload::Handle<Option<DynLoggingLayer>, FilteredRegistry>;
 
 #[cfg_attr(mobile, tauri::mobile_entry_point)]
-pub async fn run(recording_logging_handle: LoggingHandle) {
+pub async fn run(recording_logging_handle: LoggingHandle, logs_dir: PathBuf) {
     ffmpeg::init()
         .map_err(|e| {
             error!("Failed to initialize ffmpeg: {e}");
@@ -2256,6 +2250,7 @@ pub async fn run(recording_logging_handle: LoggingHandle) {
                                 .map(|v| v.server_url.clone())
                         })
                         .unwrap_or_else(|| "https://cap.so".to_string()),
+                    logs_dir: logs_dir.clone(),
                 })));
 
                 app.manage(Arc::new(RwLock::new(
diff --git a/apps/desktop/src-tauri/src/logging.rs b/apps/desktop/src-tauri/src/logging.rs
@@ -0,0 +1,83 @@
+use crate::{ArcLock, web_api::ManagerExt};
+use std::{fs, path::PathBuf};
+use tauri::{AppHandle, Manager};
+
+async fn get_latest_log_file(app: &AppHandle) -> Option<PathBuf> {
+    let logs_dir = app
+        .state::<ArcLock<crate::App>>()
+        .read()
+        .await
+        .logs_dir
+        .clone();
+
+    let entries = fs::read_dir(&logs_dir).ok()?;
+    let mut log_files: Vec<_> = entries
+        .filter_map(|entry| {
+            let entry = entry.ok()?;
+            let path = entry.path();
+            if path.is_file() && path.file_name()?.to_str()?.contains("cap-desktop.log") {
+                let metadata = fs::metadata(&path).ok()?;
+                let modified = metadata.modified().ok()?;
+                Some((path, modified))
+            } else {
+                None
+            }
+        })
+        .collect();
+
+    log_files.sort_by(|a, b| b.1.cmp(&a.1));
+    log_files.first().map(|(path, _)| path.clone())
+}
+
+pub async fn upload_log_file(app: &AppHandle) -> Result<(), String> {
+    let log_file = get_latest_log_file(app).await.ok_or("No log file found")?;
+
+    let metadata =
+        fs::metadata(&log_file).map_err(|e| format!("Failed to read log file metadata: {}", e))?;
+    let file_size = metadata.len();
+
+    const MAX_SIZE: u64 = 1 * 1024 * 1024;
+
+    let log_content = if file_size > MAX_SIZE {
+        let content =
+            fs::read_to_string(&log_file).map_err(|e| format!("Failed to read log file: {}", e))?;
+
+        let header = format!(
+            "⚠️ Log file truncated (original size: {} bytes, showing last ~1MB)\n\n",
+            file_size
+        );
+        let max_content_size = (MAX_SIZE as usize) - header.len();
+
+        if content.len() > max_content_size {
+            let start_pos = content.len() - max_content_size;
+            let truncated = &content[start_pos..];
+            if let Some(newline_pos) = truncated.find('\n') {
+                format!("{}{}", header, &truncated[newline_pos + 1..])
+            } else {
+                format!("{}{}", header, truncated)
+            }
+        } else {
+            content
+        }
+    } else {
+        fs::read_to_string(&log_file).map_err(|e| format!("Failed to read log file: {}", e))?
+    };
+
+    let form = reqwest::multipart::Form::new()
+        .text("log", log_content)
+        .text("os", std::env::consts::OS)
+        .text("version", env!("CARGO_PKG_VERSION"));
+
+    let response = app
+        .api_request("/api/desktop/logs", |client, url| {
+            client.post(url).multipart(form)
+        })
+        .await
+        .map_err(|e| format!("Failed to upload logs: {}", e))?;
+
+    if !response.status().is_success() {
+        return Err(format!("Upload failed with status: {}", response.status()));
+    }
+
+    Ok(())
+}
diff --git a/apps/desktop/src-tauri/src/main.rs b/apps/desktop/src-tauri/src/main.rs
@@ -134,5 +134,5 @@ fn main() {
         .enable_all()
         .build()
         .expect("Failed to build multi threaded tokio runtime")
-        .block_on(cap_desktop_lib::run(handle));
+        .block_on(cap_desktop_lib::run(handle, logs_dir));
 }
diff --git a/apps/desktop/src-tauri/src/thumbnails/mod.rs b/apps/desktop/src-tauri/src/thumbnails/mod.rs
@@ -102,7 +102,6 @@ pub async fn collect_displays_with_thumbnails() -> Result<Vec<CaptureDisplayWith
 pub async fn collect_windows_with_thumbnails() -> Result<Vec<CaptureWindowWithThumbnail>, String> {
     let windows = list_windows();
 
-    debug!(window_count = windows.len(), "Collecting window thumbnails");
     let mut results = Vec::new();
     for (capture_window, window) in windows {
         let thumbnail = capture_window_thumbnail(&window).await;
@@ -117,22 +116,6 @@ pub async fn collect_windows_with_thumbnails() -> Result<Vec<CaptureWindowWithTh
             }
         });
 
-        if thumbnail.is_none() {
-            warn!(
-                window_id = ?capture_window.id,
-                window_name = %capture_window.name,
-                owner_name = %capture_window.owner_name,
-                "Window thumbnail capture returned None",
-            );
-        } else {
-            debug!(
-                window_id = ?capture_window.id,
-                window_name = %capture_window.name,
-                owner_name = %capture_window.owner_name,
-                "Captured window thumbnail",
-            );
-        }
-
         results.push(CaptureWindowWithThumbnail {
             id: capture_window.id,
             name: capture_window.name,
@@ -145,7 +128,5 @@ pub async fn collect_windows_with_thumbnails() -> Result<Vec<CaptureWindowWithTh
         });
     }
 
-    info!(windows = results.len(), "Collected window thumbnail data");
-
     Ok(results)
 }
diff --git a/apps/desktop/src-tauri/src/tray.rs b/apps/desktop/src-tauri/src/tray.rs
@@ -15,6 +15,7 @@ use tauri::{
     menu::{Menu, MenuItem},
     tray::TrayIconBuilder,
 };
+use tauri_plugin_dialog::DialogExt;
 use tauri_specta::Event;
 
 pub enum TrayItem {
@@ -23,6 +24,7 @@ pub enum TrayItem {
     PreviousRecordings,
     PreviousScreenshots,
     OpenSettings,
+    UploadLogs,
     Quit,
 }
 
@@ -34,6 +36,7 @@ impl From<TrayItem> for MenuId {
             TrayItem::PreviousRecordings => "previous_recordings",
             TrayItem::PreviousScreenshots => "previous_screenshots",
             TrayItem::OpenSettings => "open_settings",
+            TrayItem::UploadLogs => "upload_logs",
             TrayItem::Quit => "quit",
         }
         .into()
@@ -50,6 +53,7 @@ impl TryFrom<MenuId> for TrayItem {
             "previous_recordings" => Ok(TrayItem::PreviousRecordings),
             "previous_screenshots" => Ok(TrayItem::PreviousScreenshots),
             "open_settings" => Ok(TrayItem::OpenSettings),
+            "upload_logs" => Ok(TrayItem::UploadLogs),
             "quit" => Ok(TrayItem::Quit),
             value => Err(format!("Invalid tray item id {value}")),
         }
@@ -78,6 +82,7 @@ pub fn create_tray(app: &AppHandle) -> tauri::Result<()> {
             )?,
             &MenuItem::with_id(app, TrayItem::OpenSettings, "Settings", true, None::<&str>)?,
             &PredefinedMenuItem::separator(app)?,
+            &MenuItem::with_id(app, TrayItem::UploadLogs, "Upload Logs", true, None::<&str>)?,
             &MenuItem::with_id(
                 app,
                 "version",
@@ -130,6 +135,20 @@ pub fn create_tray(app: &AppHandle) -> tauri::Result<()> {
                         async move { ShowCapWindow::Settings { page: None }.show(&app).await },
                     );
                 }
+                Ok(TrayItem::UploadLogs) => {
+                    let app = app.clone();
+                    tokio::spawn(async move {
+                        match crate::logging::upload_log_file(&app).await {
+                            Ok(_) => {
+                                tracing::info!("Successfully uploaded logs");
+                            }
+                            Err(e) => {
+                                tracing::error!("Failed to upload logs: {e:#}");
+                                app.dialog().message("Failed to upload logs").show(|_| {});
+                            }
+                        }
+                    });
+                }
                 Ok(TrayItem::Quit) => {
                     app.exit(0);
                 }
diff --git a/apps/desktop/src-tauri/src/web_api.rs b/apps/desktop/src-tauri/src/web_api.rs
@@ -39,31 +39,35 @@ impl From<String> for AuthedApiError {
     }
 }
 
+fn apply_env_headers(req: reqwest::RequestBuilder) -> reqwest::RequestBuilder {
+    let mut req = req.header("X-Cap-Desktop-Version", env!("CARGO_PKG_VERSION"));
+
+    if let Ok(s) = std::env::var("VITE_VERCEL_AUTOMATION_BYPASS_SECRET") {
+        req = req.header("x-vercel-protection-bypass", s);
+    }
+
+    req
+}
+
 async fn do_authed_request(
     auth: &AuthStore,
     build: impl FnOnce(reqwest::Client, String) -> reqwest::RequestBuilder,
     url: String,
 ) -> Result<reqwest::Response, reqwest::Error> {
     let client = reqwest::Client::new();
 
-    let mut req = build(client, url)
-        .header(
-            "Authorization",
-            format!(
-                "Bearer {}",
-                match &auth.secret {
-                    AuthSecret::ApiKey { api_key } => api_key,
-                    AuthSecret::Session { token, .. } => token,
-                }
-            ),
-        )
-        .header("X-Cap-Desktop-Version", env!("CARGO_PKG_VERSION"));
-
-    if let Ok(s) = std::env::var("VITE_VERCEL_AUTOMATION_BYPASS_SECRET") {
-        req = req.header("x-vercel-protection-bypass", s);
-    }
+    let req = build(client, url).header(
+        "Authorization",
+        format!(
+            "Bearer {}",
+            match &auth.secret {
+                AuthSecret::ApiKey { api_key } => api_key,
+                AuthSecret::Session { token, .. } => token,
+            }
+        ),
+    );
 
-    req.send().await
+    apply_env_headers(req).send().await
 }
 
 pub trait ManagerExt<R: Runtime>: Manager<R> {
@@ -73,6 +77,12 @@ pub trait ManagerExt<R: Runtime>: Manager<R> {
         build: impl FnOnce(reqwest::Client, String) -> reqwest::RequestBuilder,
     ) -> Result<reqwest::Response, AuthedApiError>;
 
+    async fn api_request(
+        &self,
+        path: impl Into<String>,
+        build: impl FnOnce(reqwest::Client, String) -> reqwest::RequestBuilder,
+    ) -> Result<reqwest::Response, reqwest::Error>;
+
     async fn make_app_url(&self, pathname: impl AsRef<str>) -> String;
 }
 
@@ -99,6 +109,17 @@ impl<T: Manager<R> + Emitter<R>, R: Runtime> ManagerExt<R> for T {
         Ok(response)
     }
 
+    async fn api_request(
+        &self,
+        path: impl Into<String>,
+        build: impl FnOnce(reqwest::Client, String) -> reqwest::RequestBuilder,
+    ) -> Result<reqwest::Response, reqwest::Error> {
+        let url = self.make_app_url(path.into()).await;
+        let client = reqwest::Client::new();
+
+        apply_env_headers(build(client, url)).send().await
+    }
+
     async fn make_app_url(&self, pathname: impl AsRef<str>) -> String {
         let app_state = self.state::<ArcLock<crate::App>>();
         let server_url = &app_state.read().await.server_url;
diff --git a/apps/web/app/api/desktop/[...route]/root.ts b/apps/web/app/api/desktop/[...route]/root.ts
diff --git a/packages/env/server.ts b/packages/env/server.ts

Original file line number	Diff line number	Diff line change
`@@ -134,5 +134,5 @@ fn main() {`
`134`	`134`	`.enable_all()`
`135`	`135`	`.build()`
`136`	`136`	`.expect("Failed to build multi threaded tokio runtime")`
`137`		`- .block_on(cap_desktop_lib::run(handle));`
	`137`	`+ .block_on(cap_desktop_lib::run(handle, logs_dir));`
`138`	`138`	`}`