Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell scripts to launch adventure mode and adventure editor have CRLF line terminators. #2220

Closed
janAkali opened this issue Jan 9, 2023 · 2 comments

Comments

@janAkali
Copy link

janAkali commented Jan 9, 2023

Desktop (please complete the following information):

  • OS: Ubuntu 18.04 aarch64
  • Forge: 1.6.54.SNAPSHOT-2023.1.8
  • Java: openjdk 17.0.5 2022-10-18

Describe the bug
Shell scripts to launch adventure mode and adventure editor have CRLF line terminators.
That causes shell to fail executing them.

To Reproduce
Steps to reproduce the behavior:

  1. extract snapshot archive
  2. open terminal
  3. make script executable: sudo chmod +x forge-adventure.sh
  4. run the script: ./forge-adventure.sh
  5. See error
  6. convert script with dos2unix: dos2unix ./forge-adventure.sh
  7. now shell script work as expected

Expected behavior
Forge-adventure app starts.

Screenshots
crlf

Affected files
https://github.com/Card-Forge/forge/blob/master/forge-gui-mobile-dev/src/main/config/forge-adventure.sh
https://github.com/Card-Forge/forge/blob/master/forge-adventure/src/main/config/forge-adventure-editor.sh

@github-actions
Copy link

This issue has not been updated in a while and has now been marked as stale. Stale messages will be auto closed.

@github-actions
Copy link

github-actions bot commented May 4, 2023

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as completed May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant