Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CantLose and CantWin as StaticAbilities/CantHappen #4757

Closed
4 tasks done
Hanmac opened this issue Feb 28, 2024 · 2 comments · Fixed by #6024
Closed
4 tasks done

CantLose and CantWin as StaticAbilities/CantHappen #4757

Hanmac opened this issue Feb 28, 2024 · 2 comments · Fixed by #6024
Labels

Comments

@Hanmac
Copy link
Contributor

Hanmac commented Feb 28, 2024

Cases:

  • "You can't win the game." → StaticAbility
  • "You can't lose the game." → GameLoss Replacement + GameLossReason parameter
    • "You don't lose the game for having 0 or less life."
    • "You don't lose the game for drawing from an empty library."

Similar to other #3307, "CantLose" and "CantWin" should be via StaticAbilities instead of keywords
CantHappen Replacement would be fine too

Also @tool4ever "Your opponents can't win the game." keyword probably doesn't exist

SVar:STCantLose:Mode$ Continuous | Affected$ You | AddKeyword$ You can't lose the game. & Your opponents can't win the game. | Description$ You can't lose the game. Your opponents can't win the game.

@tool4ever
Copy link
Contributor

Hmn, GameLoss Replacement already exists there

@Hanmac Hanmac changed the title CantLose and CantWin as StaticAbilities CantLose and CantWin as StaticAbilities/CantHappen Feb 28, 2024
@Hanmac
Copy link
Contributor Author

Hanmac commented Feb 28, 2024

Hmn, GameLoss Replacement already exists there

CantHappen is fine too i think

i need to make a Meta ticket for the Player.hasKeyword("string") stuff to be changed into Static or CantHappen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants